I REALLY like to keep things separated and I like my functions to be small, within reason. However I am making the assumption that myself and anyone else who comes back to change the code will be using tools that let them index or tag the source, enabeling them to hit some shortcut on a function to jump into that code to see what it does and where it comes from or where else it is used. I know lots of people work very well without these conveniences, for me though, I find it really helps me work out where things are a lot quicker.
Either way with or without the above I don not like to scan through reams of sqlalchemy constructs in the controller.... On Tue, Apr 6, 2010 at 10:54 PM, Jonathan Vanasco <jonat...@findmeon.com>wrote: > On Apr 4, 4:28 pm, cd34 <mcd...@gmail.com> wrote: > > > While the controller is cleaner, does that really make it more > > readable? From a maintainability standpoint, would someone new to the > > code be able to see what that action was doing reasonably quickly? > > If i were going for code readability, I don't know. > > Usually I go for application maintainability. Looking at the original > code , this bigtask() class looked to be a logging functionality that > is used across multiple controllers and actions. i'm inclined to > refactor code like that into helper functions , so I only need to > update them in the smallest amount of places when the objects > interface / methods change. assuming bigtask() adds a new column, and > is called in a dozen places, I'd rather only edit 1 invocation of the > method to pull the request params -- not 12. > > -- > You received this message because you are subscribed to the Google Groups > "pylons-discuss" group. > To post to this group, send email to pylons-disc...@googlegroups.com. > To unsubscribe from this group, send email to > pylons-discuss+unsubscr...@googlegroups.com<pylons-discuss%2bunsubscr...@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/pylons-discuss?hl=en. > > -- You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To post to this group, send email to pylons-disc...@googlegroups.com. To unsubscribe from this group, send email to pylons-discuss+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/pylons-discuss?hl=en.
