Hi,
Debian/Ubuntu are trying to build packages with some hardening flags by
default, and PyMOL fails to build with -Werror=format-security on in one
place:
|contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp: In function
|'int {anonymous}::write_timestep(void*, const molfile_timestep_t*)':
|contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp:1986:31: error:
|format not a string literal and no format arguments
|[-Werror=format-security]
| fprintf(stderr, e.what());
The attached patch fixes this, does it look right?
Michael
--- pymol/contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp.orig 2014-09-14 16:10:29.326095576 +0200
+++ pymol/contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp 2014-09-14 16:12:35.711799633 +0200
@@ -1983,7 +1983,7 @@
}
}
catch (std::exception &e) {
- fprintf(stderr, e.what());
+ fprintf(stderr, "Cannot write timestamp to mae file: %s\n", e.what());
return MOLFILE_ERROR;
}
return MOLFILE_SUCCESS;
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
PyMOL-users mailing list (PyMOL-users@lists.sourceforge.net)
Info Page: https://lists.sourceforge.net/lists/listinfo/pymol-users
Archives: http://www.mail-archive.com/pymol-users@lists.sourceforge.net
