On 1 April 2017 at 23:27, Donald Stufft <don...@stufft.io> wrote: > To make it clearer, what I’m asking here is what do we want to do about > this? Do we want to just auto clear the requested changes thing whenever the > PR author pushes changes? I think so, for what that looks like I have a demo > at https://github.com/dstufft/test/pull/2. So BrownTruck would dismiss it > with a short comment like “Auto Dismissing previous review due to pushed > changes”.
I assume github doesn't have a built in means for the PR author to flag their PR as "Request for change addressed"? If they did, that would be the ideal solution. It's basically (2) but with "normal github workflow" rather than something custom we implement. My problem with a custom solution is as you say, it means contributors have to learn a particular workflow just to interact effectively with us. Paul
