(Sorry for not replying earlier, I've been terribly busy for the last few days.)

On 21.05.2010 14:05, ext Mark Summerfield wrote:
On 2010-05-20, Hugo Parente Lima wrote:
Hi,

Just a RFC about naming issues in PSEP100.

To create a signal we use a class called "signal", it's a class, not a
function, this raises the following some issue:

- If it's a class, why the name starts with lower case character?

My request if to change "signal" to "Signal" and "slot" to Slot" to respect
the PySide and Qt naming style rules.

We also need to change the PSEP100 text everywhere when "function" was
mentioned.

What you think? If we gonna do this, better do it before the next release.


Looks like a good change to me.

To me too. Even though PyQt apparently uses factory functions for pyqtSignal and pyqtSlot, the functionality definitely passes the Duck Test for classes: it walks like a class and quacks like a class, so it should be named like a class to cause the least amount of confusion for the users.

As an administrative matter, the PSEP has already been accepted, so according to PSEP 1 flowcharts [1], the PSEP should be rejected and then a new one made to replace it. Since that feels quite bureaucratic and silly, I suppose no-one objects if I just drop the document to DRAFT status and have it re-accepted with the same number.

[1] http://www.pyside.org/docs/pseps/psep-0001.html

Cheers,

ma.
_______________________________________________
PySide mailing list
[email protected]
http://lists.openbossa.org/listinfo/pyside

Reply via email to