Matthias Klose added the comment:
some random comments about py3k-20121004-MINGW.patch:
- Modules/_ctypes/libffi_msvc/win32.S
Please can you get rid of libffi_msvc and use libffi?
afaics, libffi has support for mingw32.
- there seem to be chunks which are unrelated to mingw, like:
@@ -830,15 +926,18 @@ class PyBuildExt(build_ext):
if have_usable_openssl:
# The _hashlib module wraps optimized implementations
# of hash functions from the OpenSSL library.
+ # NOTE: _hashlib require only OpenSSL crypto library !
exts.append( Extension('_hashlib', ['_hashopenssl.c'],
depends = ['hashlib.h'],
include_dirs = ssl_incs,
library_dirs = ssl_libs,
- libraries = ['ssl', 'crypto']) )
+ libraries = ['crypto']) )
please file separate issues.
- why setup_info.in. looks like something which could be done with
get_config_var.
- why re-reading files in setup.py, and grepping these for config options?
I think the patch would benefit from splitting it up into several
self-contained chunks.
did you try to do builds for windows and linux after this patch was applied?
----------
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue3871>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
