Christian Heimes added the comment:

Thx Kristján!

My patch maps PyUnicode to PEM encoded cert data and objects with Py_Buffer 
support to DER encoded cert data. Perhaps you like to you the same concept in 
your patch to support TextIO and BytesIO read() methods. Feel free to reuse as 
much of my patch as you like.

You don't check ERR_GET_LIB() in some places.

Could you please add a comment about extra_chain_cert in 
PySSL_CTX_use_certificate_chain_mem() and SSL_CTX_get_cert_store() in 
PySSL_CTX_load_verify_certs_mem()? The difference between the extra chain and 
the trusted store got me confused more than once. As far as I recall the 
trusted store is suppose to contain only trusted root CA. The extra chain is 
uesd to provide intermediate certs for the cert chain between a root CA and the 
service's cert.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue16487>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to