Serhiy Storchaka added the comment: > * the patch seems to include some unrelated changes, e.g. the > devanagari fixes and a few new mappings
May be. In any case I have added issue20027 as dependency. New mappings were added when enable UTF-8 locales in makelocalealias.py (I can split this in separate issue). > * the optimize step is called twice for some reason - is this > intended ? if yes, please add a comment why this is done Actually we should call it in a loop while the size of the table is decreased. > * the patch would need some tests to make sure that the removed > aliases indeed still map to the correct C locale strings Currently the makelocalealias.py is such manual test. test_locale contains multiple tests for different locales. I'll add several new cases. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20046> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com