Marc-Andre Lemburg added the comment: On 26.12.2013 22:43, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > >> Could you add a test for the optimization function ? > > I have no ideas. The optimization function is a part of the > makelocalealias.py > which ran manually very rarely (last time 3.5 year ago). It isn't exposed > outside the script and I'm not sure that it worths the complication of the > testing.
I probably wasn't clear: I meant some tests that show that the alias definitions (on the left) from the X11 file are actually mapped to the correct alias locales (on the right). >> It should make sure that a complete set of now removed locale >> names are properly optimized away, e.g. >> >> 'nl_nl': 'nl_NL.ISO8859-1', >> - 'nl_nl.88591': 'nl_NL.ISO8859-1', >> - 'nl_nl.iso88591': 'nl_NL.ISO8859-1', >> - 'nl_nl.iso885915': 'nl_NL.ISO8859-15', >> - 'nl_nl.iso885915@euro': 'nl_NL.ISO8859-15', >> - 'nl_nl.utf8@euro': 'nl_NL.UTF-8', >> - 'nl_nl@euro': 'nl_NL.ISO8859-15', > > These cases are covered by test_english and test_euro_modifier. Ok. >> 'ja_jp': 'ja_JP.eucJP', >> - 'ja_jp.ajec': 'ja_JP.eucJP', >> 'ja_jp.euc': 'ja_JP.eucJP', >> - 'ja_jp.eucjp': 'ja_JP.eucJP', >> - 'ja_jp.iso-2022-jp': 'ja_JP.JIS7', >> - 'ja_jp.iso2022jp': 'ja_JP.JIS7', >> - 'ja_jp.jis': 'ja_JP.JIS7', >> - 'ja_jp.jis7': 'ja_JP.JIS7', >> 'ja_jp.mscode': 'ja_JP.SJIS', >> 'ja_jp.pck': 'ja_JP.SJIS', >> - 'ja_jp.sjis': 'ja_JP.SJIS', >> - 'ja_jp.ujis': 'ja_JP.eucJP', > > Here is a test which includes tests for japanese cases end tests for the euc > encoding (it maps to different encodings depending on language). Thanks. I think this is good enough now. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20046> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
