INADA Naoki added the comment: pr-2237 only changes lookdict_index() function. The function is used from only dict_popitem(). So it's not performance critical part.
And microbench doesn't show significant performance changes: $ ./python.default -m perf timeit -q -l 2000 -s 'd=dict.fromkeys(str(i) for i in range(2000))' -- 'd.popitem()' Mean +- std dev: 96.1 ns +- 1.3 ns $ ./python.patched -m perf timeit -q -l 2000 -s 'd=dict.fromkeys(str(i) for i in range(2000))' -- 'd.popitem()' Mean +- std dev: 96.4 ns +- 1.3 ns ---------- title: dict: simplify lookup function -> dict: simplify lookup functions _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29304> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
