Vinay Sajip <[email protected]> added the comment:
The namer and rotator attributes are callables, not methods to be overridden.
You can certainly do this with methods and set them accordingly:
class MyHandler(BaseRotatingHandler):
def __init__(self, *args, **kwargs):
super(MyHandler, self).__init__(*args, **kwargs)
self.namer = self.my_namer
self.rotator = self.my_rotator
def my_namer(self, default_name):
return default_name # or whatever you want here
def my_rotator(self, source, dest):
os.rename(source, dest) # or whatever you want here
Having namer and rotator be callables avoids the need to subclass a handler
just to override naming and rotating functionality. So, I think this issue
should be closed as "not a bug", and the corresponding PR closed. Thanks for
your effort, though - I just think you may have misunderstood the intent of the
design.
----------
nosy: +vinay.sajip
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue38716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
