lorb <ritzer.christ...@gmail.com> added the comment:
This PR certainly does not turn them into methods. I believe it also doesn't encourage the idea that they would have to be. All it does is preventing __init__ from setting them to None in the case they are defined as methods. Would you consider it more acceptable to just turn them into class level attributes of BaseRotatingHandler instead of setting them in init? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue38716> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com