On Jul 10, 2017, at 04:57 PM, Victor Stinner wrote: >I would prefer to ask the author to squash and/or rebase his/her >commits rather than having to edit the commit message myself. I prefer >that the commit message is part of the review, and not only done by >the one who clicks on the Merge button. > >It would prefer mistakes in the commit message. > >GitHub PR UI is not ideal to review commit messages :-/
GitLab is roughly the same, and I always edit commit messages when squash merging. While ideally the author could do this, I think sensible commit messages are more important, so +1 for having the committer edit them at their discretion. -Barry _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
