On Fri, 26 Jan 2018 at 13:04 Ethan Furman <et...@stoneleaf.us> wrote:
> On 01/26/2018 09:28 AM, Mariatta Wijaya wrote: > > > So when the original PR didn't have a news entry, what should I have > seen to alert me to that? > > > > If a news entry is missing from the PR, the CI check at the bottom of > the PR will fail. > > You should see the following: > > > > bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label > found > > > > An example can be seen here (at least at the time I write this email) > > https://github.com/python/cpython/pull/5347 > > Okay, I see it in your example. Here's the PR I'm talking about: > > https://github.com/python/cpython/pull/5103 > > I see no NEWS commit, and no "missing news" alert. Did I misstep > somewhere? > No, you just missed the news entry: https://github.com/python/cpython/pull/5103/files#diff-b1662ec7a5e858b21ea9fe160546636f .
_______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/