On Thu, Jan 8, 2009 at 17:42, Benjamin Peterson <benja...@python.org> wrote: > On Thu, Jan 8, 2009 at 7:39 PM, Brett Cannon <br...@python.org> wrote: >> On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson <benja...@python.org> wrote: >>> On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon <br...@python.org> wrote: >>>> On Thu, Jan 8, 2009 at 12:43, Nick Coghlan <ncogh...@gmail.com> wrote: >>>>> >>>>> Even if we do adopt such a rule, C patches posted to the tracker should >>>>> still try to avoid including pure whitespace changes though - leaving >>>>> the whitespace changes in the patch tends to lead to patches that look >>>>> like "remove function body, add different function body" when only a >>>>> couple of lines have actually had significant changes. >>>>> >>>> >>>> That's fine with me. Correcting whitespace can be considered a committer's >>>> job. >>> >>> Maybe a rule could be added to Tools/scripts/patchcheck.py? >> >> To do what? Re-indent automatically? Or notify the person that there >> seems to be a need to re-indent some code? > > I was thinking about notifying the person that their indentation was > wrong or they had trailing whitespace. Fixing it is bonus. :)
Supporting C and header files was a plan of mine from the beginning. We will see when I get to it. =) -Brett _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
