On Tue, 24 Mar 2009 at 22:41, "Martin v. L?wis" wrote:
If the person doing the triage has made a final call, the issue can
enter the next stage. There should never be debate on the tracker, IMO
(although there often is). It might be that people disagree with a
triage, then they should appeal to python-dev, not on the issue itself.
It might be that they think the reviewer misunderstood the issue,
then they should clarify, and the reviewer should revert the status.
OK, so given this then I revise the way I understand what is happening
in the ticket I'm looking at: a reviewer has said "this patch needs
work" and the submitter has not responded. Since the behavior has been
accepted as a valid bug this means...I can either work on the patch, or
post a message asking if the submitter wants to either revise the patch
or discuss it on python-dev. In the latter case if the submitter does
not respond, then the issue continues to languish. IMO it shouldn't be
closed, because it really is a bug.
Does this match what you would expect a reviewer to do? (A person
really doing triage would of course not work on the patch themselves :)
IMO, the reviewer should *always* take action, either by asking for
more information, or by advancing the issue to the next stage.
Did I guess correctly that the process for "recommending rejection"
is to set the stage to 'commit/reject', the resolution to 'invalid'
(or whatever is appropriate) and the status to 'pending'? That
seemed to work for the issue I did it to, in that someone came
along and closed it shortly after that.
If you have permission to do so, you should just close the issue
(in that manner). If you don't have permission, you can leave a message
saying "I recommend to close the issue".
If you are unsure, you can set it to Pending, and ask for help on
python-dev. In that case, you haven't actually done triage, but merely
considered it, and determined that it looks too difficult.
OK, so I guess I've been given more power than I was expecting, and I'll
just have to step up the bar and learn to use it appropriately :)
--
R. David Murray http://www.bitdance.com
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
