On Thu, Feb 28, 2013 at 1:30 AM, Antoine Pitrou <solip...@pitrou.net> wrote: > Le Wed, 27 Feb 2013 11:33:30 -0800, > "fwierzbi...@gmail.com" <fwierzbi...@gmail.com> a écrit : >> >> There are a couple of spots that might be more controversial. For >> example, Jython has a file Lib/zlib.py that implements zlib in terms >> of the existing Java support for zlib. I do wonder if such a file is >> acceptable in CPython's Lib since its 195 lines of code would be >> entirely skipped by CPython. > > That's a bit annoying. How will we know that the code still works, even > though our buildbots don't exercise it? > Also, what happens if the code doesn't work anymore?
Agreed on those problems. Would it be possible to use a design pattern in these cases so the Jython-only code wouldn't need to be part of the CPython repo? A naive example would be refactoring zlib to allow subclassing in the way that Jython needs, and then Jython could subclass in its own repo. CPython could have tests to check the subclass "contract" that Jython needs. --Chris _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
