On 6/25/2017 12:30 AM, Serhiy Storchaka wrote:
25.06.17 06:04, Nick Coghlan пише:
On 25 June 2017 at 11:56, Terry Reedy <tjre...@udel.edu> wrote:
On 6/24/2017 7:48 PM, Brett Cannon wrote:
I should also mention that after Larry blows up Misc/NEWS into
individual
files in about a week I will add a check to Bedevere for a news file
unless
the PR is labeled as trivial.
And what if there isn't?
In particular, will Belvedere suggest adding a news entry or mandate one?
There are sometimes good reasons to have multiple
patches on an issue, whereas an issue usually gets only one news item.
All the PRs share an issue number in that case, so Bedevere should be
able to pick up that there's a pre-existing NEWS entry (even if it
isn't being added by that particular PR).
You seem to be suggesting adding a possibly incomplete entry with the
first patch. If that is so, it would be helpful if blurb could pull an
existing file for an issue into the editor.
What if the patch removes a NEWS entry?
If the news entry is proper, it should only be removed as part of
reverting the patch, but only if it is the last remaining PR for the issue.
Or fixes a number in an existing entry?
I believe bpo numbers are part of the file *name*, not part of the news
entry. (The consolidator should do the formatting.) So the issue is
changing file names. Belvedere should flag mismatches between PR title
and news file names. Changing the number in the title, which is
sometimes necessary, will create a mismatch.
--
Terry Jan Reedy
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
