On 31. 01. 23 13:12, Richard Hughes wrote:
Hey all,
I'm building python-uswid as a rpm as it's going to be needed by the fwupd-efi
package at build time in the near future. I'm also the upstream maintainer, so
I'm not against changing upstream and then tagging a new release if there's
something that needs to be fixed to build a Fedora package. I'm no python
expert, so advice very welcome.
I've uploaded a srpm here and I'd appreciate some early 40,000ft checks before
I submit a Fedora package review:
https://people.freedesktop.org/~hughsient/temp/python-uswid-0.4.1-1.fc37.src.rpm
-- the upstream is https://github.com/hughsie/python-uswid/ for the curious.
Thanks!
Hey Richard.
I agree with what Neal said, plus:
You might want to follow the current Python packaging guidelines, i.e. use this
template:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_empty_spec_file
The main added benefit for this package:
Runtime requires aromatically generated as BuildRequires, so when tests run,
they are installed and it works. Currently you don't BR
python3-{cbor2,lxml,pefile} and hence the tests might fail. I'd be surprised if
the tests pass without the runtime deps (it might indicate the tests are not
"good enough").
The added benefit is that if the package would miss runtime dependencies, it
won't build and you will realize the problem sooner.
Considering you are also the upstream, it allows you to specify test
dependencies upstream (e.g. as an [test] extra, I can help with that) and not
copy-paste the information into the spec file (I understand that if the only
tests dependency is pytest, this does not sound like a big deal, but generally,
it gets the packaging part easier).
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
python-devel mailing list -- python-devel@lists.fedoraproject.org
To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
