On Apr 30, 6:49 pm, Marc 'BlackJack' Rintsch <[EMAIL PROTECTED]> wrote:
> In <[EMAIL PROTECTED]>, Flyzone wrote:
> > for y in range(0, len(skip_lst) ):
> > if (re.search(skip_lst[y], line)):
> > skip=1
> > break
>
> Please try to avoid unnecessary indexes::
>
> for regexp in skip_list:
> if re.search(regexp, line):
> skip = True
> break
>
> And if you don't intent to count the `skip`\s a `True` seems to be more
> readable.
>
Also try to avoid compiling the same regex repeatedly:
compiled_skip_list = [re.compile(regexp) for regexp in skip_list]
...
for regexp in compiled_skip_list:
if regexp.search(line):
skip = True
break
--
http://mail.python.org/mailman/listinfo/python-list
