On Mar 18, 4:04 pm, Tino Wildenhain <t...@wildenhain.de> wrote: > John Machin wrote: > > On Mar 18, 11:25 pm, someone <petshm...@googlemail.com> wrote: > >> Hi, > > >> what is good :) style for multiline queries to database? > >> Is that one ok? > >> query = """ SELECT * FROM ( > >> SELECT a.columna, a.columnb, a.iso > >> FROM all a > >> WHERE (a.name = LOWER(%s)) ) AS c > >> JOIN other as b on c.gid = b.id > >> WHERE class = 'A' > >> ORDER BY population DESC > >> LIMIT %s;""" > > > There's no tablet of stone, like PEP 8 :-) It seems to be a matter of > > individual taste; clarity and consistency and not overdoing > > parentheses count for me. > > > IMO you have too much leading whitespace, you have "as" in upper, > > lower and no case, and I'd set out the inner select differently: > > > query = """ > > SELECT * FROM ( > > SELECT a.columna, a.columnb, a.iso > > FROM all AS a > > WHERE a.name = LOWER(%s) > > ) AS c > > JOIN other AS b ON c.gid = b.id > > WHERE class = 'A' > > ORDER BY population DESC > > LIMIT %s; > > """
Agree, that looks nicer > > And I'd not recomment SELECT * for anything beside test queries in an > interactive session or if you are going to copy tables... yes, it I know. Thank you for responce! > > Regards > Tino > > smime.p7s > 4KViewDownload -- http://mail.python.org/mailman/listinfo/python-list