Hi,

I think I have it working - I submitted two patches: one to add the column
offset to astng nodes, and then another for pylint to report on it.

In the pylint patch, I left the parseable format unchanged, because I
thought there may be compatibility issues for users of parseable. selfishly,
i just wanted this info to be passed up to the add_message of my custom
reporter, which I guess could create compatibility problems too. the tuple
passed to add_message now has 4 elements instead of 3, the 4th being the
offset (or zero).

let me know if you want me to make any changes.

thanks again,
fawce

pylint ticket with patch:
http://www.logilab.org/ticket/69220?vid=primary&_cwmsgid=0660d106aa764a4189b1f4f1faa8aa82
astng ticket with patch:
http://www.logilab.org/ticket/69217?vid=primary&_cwmsgid=091770639ada4996a455c48aa1eb70b3

On Thu, Jun 16, 2011 at 10:43 AM, John Fawcett <[email protected]> wrote:

> hehe, i was looking around in the pylint project, not the astng project
> (blush). i'm on the right track now
> thanks,
> fawce
>
>
> On Thu, Jun 16, 2011 at 10:38 AM, Sylvain Thénault <
> [email protected]> wrote:
>
>> On 16 juin 09:51, John Fawcett wrote:
>> > Hi,
>>
>> re
>>
>> > Thanks for the speedy reply. I'd love to write the patch!
>>
>> great,
>>
>> > I actually read most of the code yesterday, and I have to admit that I
>> > couldn't find any references to _ast -- could you give me a nudge in the
>> > right direction?
>>
>> start by looking at logilab.astng.rebuilder, which rebuild an astng tree
>> from python ast. That's the right place to get back the information to
>> trees that will be later manipulated by pylint.
>>
>> Then take a look at pylint reporters (eg pylint.reporters module),
>> to see how that information could be propagated until there.
>>
>> Don't hesitate to ask for more questions on the list!
>>
>> regards,
>> --
>> Sylvain Thénault                               LOGILAB, Paris (France)
>> Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
>> Développement logiciel sur mesure:       http://www.logilab.fr/services
>> CubicWeb, the semantic web framework:    http://www.cubicweb.org
>>
>>
>
_______________________________________________
Python-Projects mailing list
[email protected]
http://lists.logilab.org/mailman/listinfo/python-projects

Reply via email to