actually, I think you should drop it from the reports. it isn't useful in static reports, really it only helps in the context of an IDE where you can do something with the offset information. so maybe you should just send it to add_message so custom reporters like mine can use it, but people needn't read it in their reports.
thanks for letting me contribute! On Thu, Jun 16, 2011 at 1:22 PM, Sylvain Thénault < [email protected]> wrote: > On 16 juin 12:35, John Fawcett wrote: > > I think I have it working - I submitted two patches: one to add the > column > > offset to astng nodes, and then another for pylint to report on it. > > > > In the pylint patch, I left the parseable format unchanged, because I > > thought there may be compatibility issues for users of parseable. > selfishly, > > i just wanted this info to be passed up to the add_message of my custom > > reporter, which I guess could create compatibility problems too. the > tuple > > passed to add_message now has 4 elements instead of 3, the 4th being the > > offset (or zero). > > > > let me know if you want me to make any changes. > > all that seems perfect. I've done a minor change to your astng patch > (see on the ticket). The only thing I'm not sure about is wether we > should include that information on the default text reporter. I've > applied it anyway, it will be easy to remove if people find this > information borring. > > Many thanks for your contribution, best regards, > -- > Sylvain Thénault LOGILAB, Paris (France) > Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations > Développement logiciel sur mesure: http://www.logilab.fr/services > CubicWeb, the semantic web framework: http://www.cubicweb.org > >
_______________________________________________ Python-Projects mailing list [email protected] http://lists.logilab.org/mailman/listinfo/python-projects
