Thanks, I can't seem to stay logged in on logilab.org (over either openid or password), and my anonymous comments don't seem to stick. I don't have a particularly unusual browser setup (eg it does accept cookies....)
One question: I refactored code using the French word 'sigle'. Do you want me to change that to the related English word 'sigil' < http://en.wikipedia.org/wiki/Sigil_(computer_programming)>? > this has not been done yet for bw compat, but you should probably use 'action': 'store_true' and drop the type so one doesn't have to provide a value to activate the feature. > Historically, that was because of handling of store_true vs the configuration file but that should be ok now, though it should be tested (use generate-rcfile, check what has been generated for this option, then change it to default to yes and start pylint using this configuration file to check it's properly considered) That will make this option inconsistent with all the others, which seems a bit likely to cause confusion. I wonder if at this point it is better for pylint to just keep using -sy -iy etc. All the other comments make sense and I'll do them later this week. On Tue, Sep 11, 2012 at 6:11 PM, Sylvain Thénault < [email protected]> wrote: > On 10 septembre 11:36, Martin Pool wrote: > > My updated patch is waiting for moderation (because it's big, because of > > the patch!), but you can see it in < > > http://sourcefrog.net/patches/2012-09-10-pylint-symbols.diff> or in < > > > https://bitbucket.org/sourcefrog/pylint/changesets/tip/branch(%22symbolic-names%22) > > >. > > Sounds good. You'll found a few comments/tasks here : > https://www.logilab.org/patch/104983 (see the "tip" tab) > > -- > Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse > (09.54.03.55.76) > Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations > Développement logiciel sur mesure: http://www.logilab.fr/services > CubicWeb, the semantic web framework: http://www.cubicweb.org > -- Martin
_______________________________________________ Python-Projects mailing list [email protected] http://lists.logilab.org/mailman/listinfo/python-projects
