Hi,

>> >  I've improved some stuff with the OSM modules:
>>
>> Great!
>>
>> > 1. osm.py now caches the openlayers library (it's about 1mb in size and
>> > was
>> > downloaded every time pytrainer showed an OSM map), it stores it in
>> > .pytrainer/tmp/cache and refreshes it every 14 days.
>>
>> Sounds pretty good. There is a tickets asking for offline capabilities
>> (see https://sourceforge.net/apps/trac/pytrainer/ticket/117), this
>> seems to fit somehow mentioned feature request
>>
>
> If you are off line it will now draw the activity track, but obviously no
> OSM tiles will show up ... Which reminds me, I will also try implementing
> the thematic track to OSM (track colors changes by speed/altitude/heart
> rate)

Yep, true.

>> > 2. I've added a window to allow the user to select a private area to
>> > anonymized using OSM, this comes as a continuation to the
>> > private/anonymizing user data option, until now this area was hard coded
>> > in.
>>
>> Interesting.
>>
>> > Files that were changed:
>> > openstreetmaps.py (new code)
>> > conf.xml (new configuration option)
>> > osm.py (new code to select area)
>> > OSM_AnonSelection.glade (new widget that allows the user to select the
>> > area)
>> >
>> > It's a bit rough on the edges, Im hoping to further improve it.
>>
>> Thanks for your efforts. Improving? step by step: "premature
>> optimization is the root of all evil" ;)
>>
>> > BTW, Any chance that i can get commit permissions to these files?
>>
>> Sure! Do you have any SourceForge account?
>>
>
> Thanks, it's "ilovesquigly"

Added. Strange that you weren't added to the project yet...

>> > Changed files are attached. Do you want/need them aslo as patch versions
>> > ?
>>
>> I would prefer you to commit your changes. Policy I follow here is to
>> inspect first submissions and then grant write access to svn. You have
>> submitted several changes so far, so you are kind of reliable person
>> ;)
>
> Thanks again, Do you have some sort of coding style policy established?

Uhmmm, I would need to review pytrainer's wiki
(https://sourceforge.net/apps/trac/pytrainer/wiki/DevelopmentGuide)
kindly created by Nathan although I have to admit I don't follow those
guidelines strictly 0:)

>> Now, a question for everyone:
>>
>> I was thinking about freezing code for 1.8.1 so new features will be
>> addresed to 1.8.2, 1.9.x or 2.y depending on their scale. We still
>> have some issues regarding main window resizing and stacked bar
>> colors, so I would like to have new features (if any) in new branches
>> that woud be merged to trunk after releasing 1.8.1. What do you think?
>>
>
> Personally i think freezing is a good idea and will promote more frequent
> releases and encourge developers to close (long time) existing bugs.

I agree, thanks for sharing your thoughts.

Regards,

David

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Pytrainer-devel mailing list
Pytrainer-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pytrainer-devel

Reply via email to