jayvdb added a comment.
In https://phabricator.wikimedia.org/T129193#2120073, @Mpaa wrote: > I think that p['ns'] should not be an issue. Agree. > Actually I do not understand why the docstring in RecentChangesPageGenerator says: > > @param changetype: only iterate changes of this type ("edit" for > edits to existing pages, "new" for new pages, "log" for log > entries) > > > while, then, log is excluded. > > Wrong docstring or clause? Regarding `for x in gen if x['type'] != 'log' or 'title' in x` This is to avoid trying to generate a `Page` for a log entry where the title has been suppressed <https://www.mediawiki.org/wiki/Manual:RevisionDelete>. If the log entry has a title, it will be generated. This is a feature of `RecentChangesPageGenerator`, and it is a bug in imageuncat's `recentChanges`. git blame shows it was slightly re-arranged in https://phabricator.wikimedia.org/rPWBCfc70846aab126488e532561e094172924a81b631, and the original bug fix is https://phabricator.wikimedia.org/rPWBC996fa7e64831fdd0ea18674b6412a7513cafc9f3. So we dont want to re-implement this bug in imageuncat. (And this is a great example of why using a unified implementation in pagegenerators is a good idea: bug fixes in pagegenerators benefit all scripts that use it, and the bug fix is unlikely to be copied to separate implementations in scripts). TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, jayvdb Cc: Mpaa, gerritbot, darthbhyrava, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Lewizho99 _______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
