The main concern is losing good but on-hold patches in a big load of redundant, obsolete and problematic patches.
I start reviewing and rebasing, etc. On Sun, Feb 22, 2015 at 3:18 PM, John Mark Vandenberg <jay...@gmail.com> wrote: > On Sun, Feb 22, 2015 at 10:33 PM, Amir Ladsgroup <ladsgr...@gmail.com> > wrote: > > So what do you suggest? If a CS is old enough, rebase is the least of the > > problems. > > What is the problem that you are trying to solve? > > Gerrit allows filtering by review status using url parameters, etc, so > 'too many patches' is hardly a problem. You can bookmark patches > which are not -1'd. > > If there are patches which are fundamentally wrong, adding -2 and > abandoning them is helpful. Reviewing possibly problematic patches is > helpful. Rebasing other peoples patches is helpful, especially if you > also address the minor review issues. > > Many of the patches have put on hold due to other larger problems; the > dependencies are sometimes explained in the comments; if not, asking > why a good patch is on hold is useful. > > But pushing old patches onto the top of the queue for no reason and > without a review comment, that is not helpful. > > -- > John Vandenberg > > _______________________________________________ > Pywikipedia-l mailing list > Pywikipedia-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l > -- Amir
_______________________________________________ Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
