On Thu, 2015-03-12 at 07:57 -0700, Adam Williamson wrote: > On 2015-03-12 02:50, Josef Skladanka wrote: > > Adam, > > > > please set these up for review in Phabricator. I strongly suspect > > (given the time that I spent looking at the changes so far) that > > some discussion will be required, and Phab is _the_ place to do > > it. Also, please make sure to rebase your repos to their current > > state, before creating the phab reviews. > > > > For further development, I'd suggest creating an account on > > Bitbucket, and using the "core" repos - all the FedoraQA Devs can > > write to the repos, and all the "admins" and administer it. Once > > you have the accound, I'll add you to the Dev group, and having a > > "feature" branch in the core repo seems quite better, given the > > development work-flows we currently adhere to. > > Sure, will do. IIRC, when I sent my last round, you didn't have the > openQA stuff set up for review in Phab so you asked for email, so I > just > figured to carry on that way.
I've now pushed my 'live' branches into Bitbucket. Haven't yet filed review requests, I want to look over the 'check_condition' stuff carefully first, but I've addressed all the other review notes, I think. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/qa-devel