> > Speaking of lists, you and Tim were mentioning white/blacklists, also > > critpath set. So what is the ideal set of packages we should run on > > initially? All packages? Only critpath packages? Only libraries included > > in critpath? In case we should run just on libraries, any good > > recommendation how to recognize that (better than matching "lib*" in > > package name)? We would need to make the decision without downloading the > > package, but I guess we could query koji or repo metadata if necessary. > > With latest commit [1] in libabigail taskotron task, ABI comparison > will occur only on shared libraries because we call abipkgdiff with > --dso-only option. So, if a package doesn't contains any library file, > it won't run abi checks on files available in package.There is a > related bug[2] which has already been fixed and will be available in > next libabigail release. So, there is no need to look specifically for > lib* package. Also, packages providing libraries may not start/contain > *lib* (e.g. elfutils) in its name.
I don't see any libraries in elfutils, they are in elfutils-libs, byt yes, you're right, we can't rely on package names. > > So, let's say we initially start with packages available in > critpath[3], then we don't have to worry whether a package provides > any shared library or not. Let me try this another way. Let's assume we can detect whether a certain package contains an *.so (or *.so.N+) file. Can we use this to decide which packages to run libabigail on? Or does libabigail run checks on more files than just *.so (now that we're using --dso-only)? I'm asking, because I expect this request ("run my task on packages containing shared libraries/files or certain other kind") is going to be quite common in the future and I think we should cover it somehow (and I have an idea how). I understand that currently we can run libabigail on everything, and if there are no libraries inside, nothing bad happens. But it's not very efficient, and that's why I'm interested to learn how exactly to distinguish packages libabigail is useful for from packages libabigail just skips. Thanks. _______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org