On Fri, 3 Feb 2017 17:05:04 -0500 (EST) Kamil Paral <kpa...@redhat.com> wrote:
> I spent a bit of time fixing minor issues in our test suite and > makefiles and would like to do the following further changes across > all our taskotron projects: > > 1. run the test suite while inside virtualenv with simple `pytest` > command > 2. run the test suite outside of virtualenv with `make test` or `doit > test` and recommend this approach in readme > 3. use a separate virtualenv when running under `make test`, without > --system-site-packages if possible, and ensure up-to-date deps are > always installed, to eliminate any differences that can occur on > different setups > 4. configure pytest to print out coverage by default, so that it > shows up for both `pytest` and `make test` > > Any concerns or different suggestions? Most of this makes sense but I wanted to propose some small tweaks to what you're talking about here. tox is designed to deal with virtualenv creation/manipulation, I wonder if it would be wise to start going in that direction instead of doing it in a makefile. I had been hoping to take the dodo.py file from libtaskotron and use most of it across all of our related projects but doit is a much less common tool than make is. I do think that many things would be easier to do with doit than make, though: - we could check for the presense of required RPMs with doit, though - something along the lines of 'doit test' coming back with "you need to install X, Y and Z rpms before running the test suite" - the docs building that I built into the buildbot on qa.fp.o pretty much needs doit and some of the generic-ish methods in the libtaskotron dodo.py file. I wonder if effort would be better spent getting those dodo.py files working instead of improving the makefiles. Either way, it'd be nice to improve things a bit. Tim
pgpSYx3ZVBLrN.pgp
Description: OpenPGP digital signature
_______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org
