On Wed, Sep 02, 2015 at 08:35:37AM +0200, Alberto Garcia wrote: > On Wed 02 Sep 2015 12:30:15 AM CEST, Jeff Cody <jc...@redhat.com> wrote: > > > Multiple sub-systems in QEMU may find it useful to generate IDs > > for objects that a user may reference via QMP or HMP. This patch > > presents a standardized way to do it, so that automatic ID generation > > follows the same rules. > > > + > > +typedef enum IdSubSystems { > > + ID_QDEV, > > + ID_BLOCK, > > + ID_MAX /* last element, used as array size */ > > +} IdSubSystems; > > + > > +char *id_generate(IdSubSystems); > > Not that it matters much, but it seems that everywhere else in the QEMU > source code the rule is to name the parameters in function prototypes. >
Indeed... another syntactic tweak to make if a v3 is needed (or a maintainer insists!) > Otherwise, the patch looks good! > > Reviewed-by: Alberto Garcia <be...@igalia.com> > > Berto Thanks! -Jeff