Am 02.09.2015 um 00:30 hat Jeff Cody geschrieben: > Changes from RFC v1: > > Patch 1: Several typos / grammatical errors (thanks Eric, John) > Make id_subsys_str[] const pointer to const strings (thanks Eric) > Moved id_subsys_str[] out from id_generate() (thanks John) > Assert on null string for given id (thanks Eric) > Zero-pad the 2-digit random # (thanks John) > > Patch 2: None > > Born from the conversation on qemu-devel, this generation scheme uses the > format ultimately proposed by Kevin, after list discussion. > > It attempts to keep the ID strings as small as possible, while fulfilling: > > 1.) Guarantee no collisions with a user-specified ID > 2.) Identify the sub-system the ID belongs to > 3.) Guarantee of uniqueness > 4.) Spoiling predictibility, to avoid creating an assumption > of object ordering and parsing (i.e., we don't want users to think > they can guess the next ID based on prior behavior). > > See patch 1 for the generation scheme details.
Thanks, applied to the block branch. While applying, I fixed up the id_generate() declaration in the header file to include an identifier for the parameter. Kevin
