On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini <pbonz...@redhat.com> wrote: > Maybe patch 4 can use distlib.scripts as well to create the check script in > the build directory? (Yes that's another mkvenv functionality...) On a phone > and don't have the docs at hand, so I am not sure. If not, your solution is > good enough. > > Apart from this the only issue is the speed. IIRC having a prebuilt .whl > would fix it, I think for Meson we observed that the slow part was building > the wheel. Possibilities: > > 1) using --no-pep517 if that also speeds it up? > > 2) already removing the sources to qemu.qmp since that's the plan anyway; and > then, if you want editability you can install the package with --user > --editable, i.e. outside the venv
Nope, it's 3 second always and 1.5 even with the wheel. Maybe replace qemu.qmp with a wheel and leaving PYTHONPATH for the rest? Paolo > Paolo > >> >> John Snow (6): >> experiment: add mkvenv install >> build, tests: Add qemu in-tree packages to pyvenv at configure time. >> iotests: get rid of '..' in path environment output >> iotests: use the correct python to run linters >> iotests: use pyvenv/bin/python3 to launch child test processes >> iotests: don't add qemu.git/python to PYTHONPATH >> >> configure | 31 +++++++++++++++++++++++++++ >> python/scripts/mkvenv.py | 40 +++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/linters.py | 2 +- >> tests/qemu-iotests/testenv.py | 21 ++++++++++++------ >> 4 files changed, 87 insertions(+), 7 deletions(-) >> >> -- >> 2.40.1 >> >>