On Wed, Feb 14, 2024 at 02:13:45PM +0900, Akihiko Odaki wrote: > Release VFs failed to realize just as we do in unregister_vfs(). > > Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization > (SR/IOV)") > Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
Is this fixing an old bug or a bug introduced by a previous patch? > --- > hw/pci/pcie_sriov.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c > index 9ba34cf8f8ed..9d668b8d6c17 100644 > --- a/hw/pci/pcie_sriov.c > +++ b/hw/pci/pcie_sriov.c > @@ -91,6 +91,8 @@ bool pcie_sriov_pf_init(PCIDevice *dev, uint16_t offset, > vf->exp.sriov_vf.vf_number = i; > > if (!qdev_realize(&vf->qdev, bus, errp)) { > + object_unparent(OBJECT(vf)); > + object_unref(vf); > unrealize_vfs(dev, i); > return false; > } > > -- > 2.43.0