TYPE_FSL_ESDHC_BE maches real hardware more closely by reusing code of TYPE_IMX_USDHC. For example, it fixes Linux to flood the guest console with "mmc0: Internal clock never stabilised" messages in the QEMU advent calendar 2018 day 19 image.
Reported-by: Thomas Huth <[email protected]> Signed-off-by: Bernhard Beschow <[email protected]> --- hw/ppc/e500.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index eb0d3a418e..d6ca2e8563 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -1036,15 +1036,7 @@ void ppce500_init(MachineState *machine) memory_region_add_subregion(ccsr_addr_space, MPC85XX_ESDHC_REGS_OFFSET, sysbus_mmio_get_region(s, 0)); - /* - * Compatible with: - * - SD Host Controller Specification Version 2.0 Part A2 - * (See MPC8569E Reference Manual) - */ - dev = qdev_new(TYPE_SYSBUS_SDHCI); - qdev_prop_set_uint8(dev, "sd-spec-version", 2); - qdev_prop_set_uint8(dev, "endianness", DEVICE_BIG_ENDIAN); - qdev_prop_set_uint8(dev, "vendor", SDHCI_VENDOR_FSL); + dev = qdev_new(TYPE_FSL_ESDHC_BE); s = SYS_BUS_DEVICE(dev); sysbus_realize_and_unref(s, &error_fatal); sysbus_connect_irq(s, 0, qdev_get_gpio_in(mpicdev, MPC85XX_ESDHC_IRQ)); -- 2.52.0
