On 06.11.19 16:44, Maxim Levitsky wrote: > On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> tests/qemu-iotests/common.filter | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/tests/qemu-iotests/common.filter >> b/tests/qemu-iotests/common.filter >> index 9f418b4881..63bc6f6f26 100644 >> --- a/tests/qemu-iotests/common.filter >> +++ b/tests/qemu-iotests/common.filter >> @@ -227,5 +227,29 @@ _filter_qmp_empty_return() >> grep -v '{"return": {}}' >> } >> >> +_filter_json_filename() >> +{ >> + $PYTHON -c 'import sys >> +result, *fnames = sys.stdin.read().split("json:{") > > Very minor nitpick, maybe I would give 'fnames' a more generic name, > since its is just result of a split, thus not really a list of filenames. > Feel free to ignore that though.
Hm... It is a list of filenames, namely of all nested json:{} filenames. I could call it fname_split, but I actually think fnames is not too wrong. In any case, thanks for reviewing again! Max
signature.asc
Description: OpenPGP digital signature