Patchew URL: https://patchew.org/QEMU/20200514063112.1457125-1-raphael.p...@hetzner.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200514063112.1457125-1-raphael.p...@hetzner.com Subject: [PATCH v2 0/1] qemu-nbd: Close inherited stderr Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200514122334.25089-1-kra...@redhat.com -> patchew/20200514122334.25089-1-kra...@redhat.com * [new tag] patchew/20200514123729.156283-1-fran...@linux.ibm.com -> patchew/20200514123729.156283-1-fran...@linux.ibm.com Switched to a new branch 'test' 76bb928 qemu-nbd: Close inherited stderr === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #20: FILE: qemu-nbd.c:919: + /* Remember parents stderr only if the fork option is set. ERROR: suspect code indent for conditional statements (12, 14) #23: FILE: qemu-nbd.c:922: + if (fork_process) { + old_stderr = dup(STDERR_FILENO); ERROR: Missing Signed-off-by: line(s) total: 2 errors, 1 warnings, 14 lines checked Commit 76bb928d8364 (qemu-nbd: Close inherited stderr) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200514063112.1457125-1-raphael.p...@hetzner.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com