On 5/14/20 9:29 AM, Eric Blake wrote:
WARNING: Block comments use a leading /* on a separate line
#20: FILE: qemu-nbd.c:919:
+ /* Remember parents stderr only if the fork option is set.
The comment could use some grammar help (s/parents/parent's/), and in
truth, I don't think it adds much beyond what the code itself is already
doing, so rather than adding another line to silence patchew, you could
instead just eliminate the comment and life would still be fine. Or if
you want a one-line comment, I might suggest:
/* Remember parent's stderr if we will restoring it. */
It helps if I don't hit 'send' too early.
/* Remember parent's stderr if we will be restoring it. */
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
