Kevin Wolf <kw...@redhat.com> writes: > Am 03.09.2020 um 12:49 hat Markus Armbruster geschrieben: >> Markus Armbruster <arm...@redhat.com> writes: >> >> > Markus Armbruster <arm...@redhat.com> writes: >> > >> >> I let this series slide to get my Error API rework done, along with much >> >> else. My sincere apologies! >> >> >> >> Unsurprisingly, it needs a rebase now. I suggest to let me review it as >> >> is first. >> > >> > I'm done with v6. Summary: >> > >> > * A few trivial things to correct here and there. >> > >> > * A few ideas to improve things in relatively minor ways. >> > >> > * PATCH 03 looks "why bother" to me until PATCH 09 makes me suspect you >> > did the former to enable the latter. If you had captured that in your >> > commit message back then, like you did for the similar PATCH 05, I >> > wouldn't be scratching my head now :) >> > >> > * I dislike PATCH 06, and would like to explore an alternative idea. >> > >> > * PATCH 08 makes hairy monitor code even hairier, but I don't have >> > better ideas. >> > >> > * I don't feel comfortable as a sole reviewer of the AIO magic in PATCH >> > 10-12. Let's ask Stefan for an eye-over. >> > >> > I'd like to proceed as follows. You rebase, and address "easy" review >> > comments (you decide what's easy). Post as v7, cc'ing Stefan for the >> > AIO magic and David Gilbert for HMP. While they review (hopefully), I >> > explore a replacement for PATCH 06. And then we touch bases and decide >> > how to get this thing wrapped. >> >> I explored: >> >> Subject: Ways to do per-coroutine properties (was: [PATCH v6 06/12] >> monitor: Make current monitor a per-coroutine property) >> Date: Fri, 07 Aug 2020 15:09:19 +0200 (3 weeks, 5 days, 21 hours ago) >> Message-ID: <87a6z6wqkg.fsf...@dusky.pond.sub.org> >> >> May I have v7? Feel free to keep your PATCH 06. If I decide to replace >> it, I can do it myself, possibly on top. > > It's one of the next things on my list. I can't promise anything more > specific, though.
Take your time. I've certainly taken mine and then some.