On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > Disable following tests on msys2/mingw > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', > > tasn1, crypto], > > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c', > > tasn1, crypto], > > 'test-io-channel-tls': ['io-channel-helpers.c', > 'crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', > > tasn1, io, crypto]} > > Why ? GNUTLS is available on Windows and if it is enabled > at build time, then we should certainly be running the tests. > Don't know why., the header disable it totally. and it's requires CONFIG_TASN1, don't know if CONFIG_TASN1 works under win32 ``` #ifndef TESTS_CRYPTO_TLS_X509_HELPERS_H #define TESTS_CRYPTO_TLS_X509_HELPERS_H #include <gnutls/gnutls.h> #include <gnutls/x509.h> #if !(defined WIN32) && \ defined(CONFIG_TASN1) # define QCRYPTO_HAVE_TLS_TEST_SUPPORT #endif #ifdef QCRYPTO_HAVE_TLS_TEST_SUPPORT # include <libtasn1.h> ``` > > > > > Signed-off-by: Yonggang Luo <luoyongg...@gmail.com> > > --- > > tests/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tests/meson.build b/tests/meson.build > > index 998e4c48f9..b470a90e3a 100644 > > --- a/tests/meson.build > > +++ b/tests/meson.build > > @@ -145,7 +145,8 @@ if have_block > > 'test-crypto-block': [io], > > } > > if 'CONFIG_GNUTLS' in config_host and \ > > - 'CONFIG_TASN1' in config_host > > + 'CONFIG_TASN1' in config_host and \ > > + 'CONFIG_POSIX' in config_host > > tests += { > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', > > tasn1, crypto], > > -- > > 2.28.0.windows.1 > > > > > > Regards, > Daniel > -- > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo