On Wed, Sep 09, 2020 at 04:30:26PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:22 PM Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > > > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé <berra...@redhat.com> > > > wrote: > > > > > > > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > > > > Disable following tests on msys2/mingw > > > > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > > > > 'pkix_asn1_tab.c', > > > > > tasn1, crypto], > > > > > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', > > > > 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c', > > > > > tasn1, crypto], > > > > > 'test-io-channel-tls': ['io-channel-helpers.c', > > > > 'crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', > > > > > tasn1, io, crypto]} > > > > > > > > Why ? GNUTLS is available on Windows and if it is enabled > > > > at build time, then we should certainly be running the tests. > > > > > > > > > > Don't know why., the header disable it totally. > > > > Yes, I know the source disables it, because it creates various > > files and no effort has been made to use WIndows filename > > building code. > > > > Given that it is already disabled in the source, why do we need > > to disable it a second time in meson.build ? > > > Because when there is no testcase ,the test runner would complain > ERROR - missing test plan
Ok, please say that in the commit message to explain why the change is needed. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|