On 6/4/21 11:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken and besides it's not likely this is
What's changing? I'm not deeply familiar with aarch64. Why is this
assumption about to be broken?
improving out coverage by much. Test the "virt" machine for both arm
and aarch64 as it can be used by either architecture.
Sounds fine to me, but I didn't write this part of the test. Thomas, you
wrote this section IIRC -- does this reduce coverage in any meaningful way?
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
---
tests/qtest/cdrom-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index 5af944a5fb..1e74354624 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -220,13 +220,16 @@ int main(int argc, char **argv)
"magnum", "malta", "pica61", NULL
};
add_cdrom_param_tests(mips64machines);
- } else if (g_str_equal(arch, "arm") || g_str_equal(arch, "aarch64")) {
+ } else if (g_str_equal(arch, "arm")) {
const char *armmachines[] = {
"realview-eb", "realview-eb-mpcore", "realview-pb-a8",
"realview-pbx-a9", "versatileab", "versatilepb", "vexpress-a15",
"vexpress-a9", "virt", NULL
};
add_cdrom_param_tests(armmachines);
+ } else if (g_str_equal(arch, "aarch64")) {
+ const char *aarch64machines[] = { "virt", NULL };
+ add_cdrom_param_tests(aarch64machines);
} else {
const char *nonemachine[] = { "none", NULL };
add_cdrom_param_tests(nonemachine);
