On 17.09.21 07:40, John Snow wrote:
Disable the aqmp logger, which likes to (at the moment) print out
intermediate warnings and errors that cause session termination; disable
them so they don't interfere with the job output.

Leave any "CRITICAL" warnings enabled though, those are ones that we
should never see, no matter what.

I mean, looks OK to me, but from what I understand (i.e. little), qmp_client doesn’t log CRITICAL messages, at least I can’t see any. Only ERRORs.

I guess I’m missing some CRITICAL messages in external functions called from qmp_client.py, but shouldn’t we still keep ERRORs?

Hanna

Signed-off-by: John Snow <js...@redhat.com>
---
  tests/qemu-iotests/iotests.py | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 273d2777ae..47e5f9738b 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -1383,6 +1383,8 @@ def execute_setup_common(supported_fmts: Sequence[str] = 
(),
      if debug:
          sys.argv.remove('-d')
      logging.basicConfig(level=(logging.DEBUG if debug else logging.WARN))
+    if not debug:
+        logging.getLogger("qemu.aqmp.qmp_client").setLevel(logging.CRITICAL)
_verify_image_format(supported_fmts, unsupported_fmts)
      _verify_protocol(supported_protocols, unsupported_protocols)


Reply via email to