Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 04eeeec69771958bc28564a05a40919e201ba862
https://github.com/qemu/qemu/commit/04eeeec69771958bc28564a05a40919e201ba862
Author: Dr. David Alan Gilbert <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M crypto/der.c
M crypto/der.h
Log Message:
-----------
crypto: Remove unused DER string functions
qcrypto_der_encode_octet_str_begin and _end have been unused
since they were added in
3b34ccad66 ("crypto: Support DER encodings")
Remove them.
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: a3472075147162c935d841b8f0571e5616947d6a
https://github.com/qemu/qemu/commit/a3472075147162c935d841b8f0571e5616947d6a
Author: Dr. David Alan Gilbert <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M include/qemu/sockets.h
M util/qemu-sockets.c
Log Message:
-----------
sockets: Remove deadcode
socket_remote_address hasn't been used since it was added in
17c55decec ("sockets: add helpers for creating SocketAddress from a socket")
inet_connect hasn't been used since 2017's
8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()")
Remove them.
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: b5b89e9bc6a20677ff59e5049ba6b89a68105b5e
https://github.com/qemu/qemu/commit/b5b89e9bc6a20677ff59e5049ba6b89a68105b5e
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M util/qemu-sockets.c
Log Message:
-----------
util: don't set SO_REUSEADDR on client sockets
Setting the SO_REUSEADDR property on a socket allows binding to a port
number that is in the TIMED_WAIT state. This is usually done on listener
sockets, to enable a server to restart itself without having to wait for
the completion of TIMED_WAIT on the port.
It is also possible, but highly unusual, to set it on client sockets. It
is rare to explicitly bind() a client socket, since it is almost always
fine to allow the kernel to auto-bind a client socket to a random free
port. Most systems will have many 10's of 1000's of free ports that
client sockets will be bound to.
eg on Linux
$ sysctl -a | grep local_port
net.ipv4.ip_local_port_range = 32768 60999
eg on OpenBSD
$ sysctl -a | grep net.inet.ip.port
net.inet.ip.portfirst=1024
net.inet.ip.portlast=49151
net.inet.ip.porthifirst=49152
net.inet.ip.porthilast=65535
A connected socket must have a unique set of value for
(protocol, localip, localport, remoteip, remoteport)
otherwise it is liable to get EADDRINUSE.
A client connection should trivially avoid EADDRINUSE if letting the
kernel auto-assign the 'localport' value, which QEMU always does.
When QEMU sets SO_REUSEADDR on a client socket on OpenBSD, however, it
upsets this situation.
The OpenBSD kernel appears to happily pick a 'localport' that is in the
TIMED_WAIT state, even if there are many other available local ports
available for use that are not in the TIMED_WAIT state.
A test program that just loops opening client sockets will start seeing
EADDRINUSE on OpenBSD when as few as 2000 ports are in TIMED_WAIT,
despite 10's of 1000's ports still being unused. This contrasts with
Linux which appears to avoid picking local ports in TIMED_WAIT state.
This problem on OpenBSD exhibits itself periodically with the migration
test failing with a message like[1]:
qemu-system-ppc64: Failed to connect to '127.0.0.1:24109': Address already in
use
While I have not been able to reproduce the OpenBSD failure in my own
testing, given the scope of what QEMU tests do, it is entirely possible
that there could be a lot of ports in TIMED_WAIT state when the
migration test runs.
Removing SO_REUSEADDR from the client sockets should not affect normal
QEMU usage, and should improve reliability on OpenBSD.
This use of SO_REUSEADDR on client sockets is highly unusual, and
appears to have been present since the very start of the QEMU socket
helpers in 2008. The orignal commit has no comment about the use of
SO_REUSEADDR on the client, so is most likely just an 16 year old
copy+paste bug.
[1] https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03427.html
https://lists.nongnu.org/archive/html/qemu-devel/2024-02/msg01572.html
Fixes: d247d25f18764402899b37c381bb696a79000b4e
Reviewed-by: Peter Xu <[email protected]>
Reviewed-by: Fabiano Rosas <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: dde538c9a76f328a92c532893e97e18785d57364
https://github.com/qemu/qemu/commit/dde538c9a76f328a92c532893e97e18785d57364
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M crypto/hash-gcrypt.c
M crypto/hash-glib.c
M crypto/hash-gnutls.c
M crypto/hash-nettle.c
Log Message:
-----------
crypto/hash: avoid overwriting user supplied result pointer
If the user provides a pre-allocated buffer for the hash result,
we must use that rather than re-allocating a new buffer.
Reported-by: Dorjoy Chowdhury <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 164f2be1b513c16dfa65f092f223310992c29828
https://github.com/qemu/qemu/commit/164f2be1b513c16dfa65f092f223310992c29828
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M tests/unit/test-crypto-hash.c
M tests/unit/test-crypto-hmac.c
Log Message:
-----------
tests: correctly validate result buffer in hash/hmac tests
Validate that the pre-allocated buffer pointer was not overwritten
by the hash/hmac APIs.
Reviewed-by: Dorjoy Chowdhury <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 769660955a62ddcb75a1f9a0d1c6c0f840d533e8
https://github.com/qemu/qemu/commit/769660955a62ddcb75a1f9a0d1c6c0f840d533e8
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M include/crypto/hash.h
M include/crypto/hmac.h
Log Message:
-----------
include/crypto: clarify @result/@result_len for hash/hmac APIs
The @result parameter passed to hash/hmac APIs may either contain
a pre-allocated buffer, or a buffer can be allocated on the fly.
Clarify these two different usage models in the API docs.
Reviewed-by: Dorjoy Chowdhury <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: f8395ce8a349245c5b7e4645e34350366b0c734b
https://github.com/qemu/qemu/commit/f8395ce8a349245c5b7e4645e34350366b0c734b
Author: Markus Armbruster <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M crypto/hash-afalg.c
Log Message:
-----------
crypto/hash-afalg: Fix broken build
Fux build broken by semantic conflict with commit
8f525028bc6 (qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo).
Fixes: 90c3dc60735a (crypto/hash-afalg: Implement new hash API)
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 46c80446b5c1caf39a7ed2d0e426c4712f8e98d2
https://github.com/qemu/qemu/commit/46c80446b5c1caf39a7ed2d0e426c4712f8e98d2
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
Log Message:
-----------
ui/vnc: don't return an empty SASL mechlist to the client
The SASL initialization phase may determine that there are no valid
mechanisms available to use. This may be because the host OS admin
forgot to install some packages, or it might be because the requested
SSF level is incompatible with available mechanisms, or other unknown
reasons.
If we return an empty mechlist to the client, they're going to get a
failure from the SASL library on their end and drop the connection.
Thus there is no point even sending this back to the client, we can
just drop the connection immediately.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: e9eabcc911a2056a91e37384f002610351ca0907
https://github.com/qemu/qemu/commit/e9eabcc911a2056a91e37384f002610351ca0907
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
Log Message:
-----------
ui/vnc: don't raise error formatting socket address for non-inet
The SASL library requires the connection's local & remote IP address to
be passed in, since some mechanism may use this information. Currently
QEMU raises an error for non-inet sockets, but it is valid to pass NULL
to the SASL library. Doing so makes SASL work on UNIX sockets.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: c0a9c92bd5a9c410a2b981f4d88f5584b55c1dfd
https://github.com/qemu/qemu/commit/c0a9c92bd5a9c410a2b981f4d88f5584b55c1dfd
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
M ui/vnc.c
M ui/vnc.h
Log Message:
-----------
ui/vnc: fix skipping SASL SSF on UNIX sockets
The 'is_unix' flag is set on the VNC server during startup, however,
a regression in:
commit 8bd22f477f68bbd7a9c88e926e7a58bf65605e39
Author: Daniel P. Berrangé <[email protected]>
Date: Fri Feb 3 12:06:46 2017 +0000
ui: extract code to connect/listen from vnc_display_open
meant we stopped setting the 'is_unix' flag when QEMU listens for
VNC sockets, only setting when QEMU does a reverse VNC connection.
Rather than fixing setting of the 'is_unix' flag, remove it, and
directly check the live client socket address. This is more robust
to a possible situation where the VNC server was listening on a
mixture of INET and UNIX sockets.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 2b69564798f3cd43ab9bdf70a96d2373cb544a9a
https://github.com/qemu/qemu/commit/2b69564798f3cd43ab9bdf70a96d2373cb544a9a
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
Log Message:
-----------
ui/vnc: don't check for SSF after SASL authentication on UNIX sockets
Although we avoid requesting an SSF when querying SASL mechanisms for a
UNIX socket client, we still mistakenly checked for availability of an
SSF once the SASL auth process is complete.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 829cb3d0eab08e4fea768926f06db1c411a2767f
https://github.com/qemu/qemu/commit/829cb3d0eab08e4fea768926f06db1c411a2767f
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
Log Message:
-----------
ui: fix handling of NULL SASL server data
The code is supposed to distinguish between SASL server data that
is NULL, vs non-NULL but zero-length. It was incorrectly checking
the 'serveroutlen' variable, rather than 'serverout' though, so
failing to distinguish the cases.
Fortunately we can fix this without breaking compatibility with
clients, as clients already know how to decode the input data
correctly.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 1a225f57f3a6bc7a9544b0aa567727f0ef51bc17
https://github.com/qemu/qemu/commit/1a225f57f3a6bc7a9544b0aa567727f0ef51bc17
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M ui/vnc-auth-sasl.c
Log Message:
-----------
ui: validate NUL byte padding in SASL client data more strictly
When the SASL data is non-NULL, the SASL protocol spec requires that
it is padded with a trailing NUL byte. QEMU discards the trailing
byte, but does not currently validate that it was in fact a NUL.
Apply strict validation to better detect any broken clients.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: c64df333f92798823c4897ae6d4bd7f49d060225
https://github.com/qemu/qemu/commit/c64df333f92798823c4897ae6d4bd7f49d060225
Author: Daniel P. Berrangé <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M .gitlab-ci.d/buildtest.yml
Log Message:
-----------
gitlab: enable afalg tests in fedora system test
The AF_ALG crypto integration for Linux is not being tested in
any CI scenario. It always requires an explicit configure time
flag to be passed to turn it on. The Fedora system test is
arbitrarily picked as the place to test it.
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Commit: 75200708cec2377425e3ca916cc5706ba22c9272
https://github.com/qemu/qemu/commit/75200708cec2377425e3ca916cc5706ba22c9272
Author: Peter Maydell <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M block/gluster.c
Log Message:
-----------
block/gluster: Use g_autofree for string in qemu_gluster_parse_json()
In the loop in qemu_gluster_parse_json() we do:
char *str = NULL;
for(...) {
str = g_strdup_printf(...);
...
if (various errors) {
goto out;
}
...
g_free(str);
str = NULL;
}
return 0;
out:
various cleanups;
g_free(str);
...
return -errno;
Coverity correctly complains that the assignment "str = NULL" at the
end of the loop is unnecessary, because we will either go back to the
top of the loop and overwrite it, or else we will exit the loop and
then exit the function without ever reading str again. The assignment
is there as defensive coding to ensure that str is only non-NULL if
it's a live allocation, so this is intentional.
We can make Coverity happier and simplify the code here by using
g_autofree, since we never need 'str' outside the loop.
Resolves: Coverity CID 1527385
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 19c1e44123d53bfae4aae38e38a4342b789a581c
https://github.com/qemu/qemu/commit/19c1e44123d53bfae4aae38e38a4342b789a581c
Author: Peter Maydell <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M block/ssh.c
Log Message:
-----------
block/ssh.c: Don't double-check that characters are hex digits
In compare_fingerprint() we effectively check whether the characters
in the fingerprint are valid hex digits twice: first we do so with
qemu_isxdigit(), but then the hex2decimal() function also has a code
path where it effectively detects an invalid digit and returns -1.
This causes Coverity to complain because it thinks that we might use
that -1 value in an expression where it would be an integer overflow.
Avoid the double-check of hex digit validity by testing the return
values from hex2decimal() rather than doing separate calls to
qemu_isxdigit().
Since this means we now use the illegal-character return value
from hex2decimal(), rewrite it from "-1" to "UINT_MAX", which
has the same effect since the return type is "unsigned" but
looks less confusing at the callsites when we detect it with
"c0 > 0xf".
Resolves: Coverity CID 1547813
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: d60bd080e783107cb876a6f16561fe03f9dcbca7
https://github.com/qemu/qemu/commit/d60bd080e783107cb876a6f16561fe03f9dcbca7
Author: Peter Maydell <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M tests/qemu-iotests/211.out
Log Message:
-----------
tests/qemu-iotests/211.out: Update to expect MapEntry 'compressed' field
In commit 52b10c9c0c68e90f in 2023 the QAPI MapEntry struct was
updated to add a 'compressed' field. That commit updated a number
of iotest expected-output files, but missed 211, which is vdi
specific. The result is that
./check -vdi
and more specifically
./check -vdi 211
fails because the expected and actual output don't match.
Update the reference output.
Cc: [email protected]
Fixes: 52b10c9c0c68e90f ("qemu-img: map: report compressed data blocks")
Signed-off-by: Peter Maydell <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 4d7c5f8335dad1aac9bf00704dab5409b9a9f4db
https://github.com/qemu/qemu/commit/4d7c5f8335dad1aac9bf00704dab5409b9a9f4db
Author: Peter Maydell <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M block/vdi.c
Log Message:
-----------
block/vdi.c: Make SECTOR_SIZE constant 64-bits
Make the VDI SECTOR_SIZE define be a 64-bit constant; this matches
how we define BDRV_SECTOR_SIZE. The benefit is that it means that we
don't need to carefully cast to 64-bits when doing operations like
"n_sectors * SECTOR_SIZE" to avoid doing a 32x32->32 multiply, which
might overflow, and which Coverity and other static analysers tend to
warn about.
The specific potential overflow Coverity is highlighting is the one
at the end of vdi_co_pwritev() where we write out n_sectors sectors
to the block map. This is very unlikely to actually overflow, since
the block map has 4 bytes per block and the maximum number of blocks
in the image must fit into a 32-bit integer. So this commit is not
fixing a real-world bug.
An inspection of all the places currently using SECTOR_SIZE in the
file shows none which care about the change in its type, except for
one call to error_setg() which needs the format string adjusting.
Resolves: Coverity CID 1508076
Suggested-by: Kevin Wolf <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: b4bc6ad1d79a0fe9c06ada7ff036578f3400258d
https://github.com/qemu/qemu/commit/b4bc6ad1d79a0fe9c06ada7ff036578f3400258d
Author: Vladimir Sementsov-Ogievskiy <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M tests/qemu-iotests/tests/backup-discard-source
Log Message:
-----------
iotests/backup-discard-source: convert size variable to be int
Make variable reusable in code for checks. Don't care to change "512 *
1024" invocations as they will be dropped in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 526c4a90c48eae2d0c37ae36ec83376b44a4cce4
https://github.com/qemu/qemu/commit/526c4a90c48eae2d0c37ae36ec83376b44a4cce4
Author: Vladimir Sementsov-Ogievskiy <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M tests/qemu-iotests/tests/backup-discard-source
Log Message:
-----------
iotests/backup-discard-source: don't use actual-size
Relying on disk usage is bad thing, and test just doesn't work on XFS.
Let's instead add a dirty bitmap to track writes to test image.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Tested-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 7452162adec25c1003d5bf0079aca52913a80e0c
https://github.com/qemu/qemu/commit/7452162adec25c1003d5bf0079aca52913a80e0c
Author: Vladimir Sementsov-Ogievskiy <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M block/block-backend.c
M qapi/block-core.json
Log Message:
-----------
qapi: add qom-path to BLOCK_IO_ERROR event
We need something more reliable than "device" (which absent in modern
interfaces) and "node-name" (which may absent, and actually don't
specify the device, which is a source of error) to make a per-device
throttling for the event in the following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 2155d2dd7f733674586119b6b4ee0f52d2032779
https://github.com/qemu/qemu/commit/2155d2dd7f733674586119b6b4ee0f52d2032779
Author: Leonid Kaplan <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M monitor/monitor.c
M qapi/block-core.json
Log Message:
-----------
block-backend: per-device throttling of BLOCK_IO_ERROR reports
BLOCK_IO_ERROR events comes from guest, so we must throttle them.
We still want per-device throttling, so let's use device id as a key.
Signed-off-by: Leonid Kaplan <[email protected]>
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: 04bbc3ee52b32ac465547bb40c1f090a1b8f315a
https://github.com/qemu/qemu/commit/04bbc3ee52b32ac465547bb40c1f090a1b8f315a
Author: Kevin Wolf <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M block/raw-format.c
Log Message:
-----------
raw-format: Fix error message for invalid offset/size
s->offset and s->size are only set at the end of the function and still
contain the old values when formatting the error message. Print the
parameters with the new values that we actually checked instead.
Fixes: 500e2434207d ('raw-format: Split raw_read_options()')
Signed-off-by: Kevin Wolf <[email protected]>
Message-ID: <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
Reviewed-by: Hanna Czenczek <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Commit: e51d8fbb7e673e487e98327fc067700b5a3edf30
https://github.com/qemu/qemu/commit/e51d8fbb7e673e487e98327fc067700b5a3edf30
Author: Peter Maydell <[email protected]>
Date: 2024-10-24 (Thu, 24 Oct 2024)
Changed paths:
M .gitlab-ci.d/buildtest.yml
M crypto/der.c
M crypto/der.h
M crypto/hash-afalg.c
M crypto/hash-gcrypt.c
M crypto/hash-glib.c
M crypto/hash-gnutls.c
M crypto/hash-nettle.c
M include/crypto/hash.h
M include/crypto/hmac.h
M include/qemu/sockets.h
M tests/unit/test-crypto-hash.c
M tests/unit/test-crypto-hmac.c
M ui/vnc-auth-sasl.c
M ui/vnc.c
M ui/vnc.h
M util/qemu-sockets.c
Log Message:
-----------
Merge tag 'misc-fixes-pull-request' of https://gitlab.com/berrange/qemu into
staging
Misc sockets, crypto and VNC fixes
* Fix rare EADDRINUSE failures on OpenBSD platforms seen
with migration
* Fix & test overwriting of hash output buffer
* Close connection instead of returning empty SASL mechlist to
VNC clients
* Fix handling of SASL SSF on VNC server UNIX sockets
* Fix handling of NULL SASL server data in VNC server
* Validate trailing NUL padding byte from SASL client
* Fix & test AF_ALG crypto backend build
* Remove unused code in sockets and crypto subsystems
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE2vOm/bJrYpEtDo4/vobrtBUQT98FAmcXscUACgkQvobrtBUQ
# T9+S+Q//W9fywFY42VnsPqIAi7Q+QPDvXrPVVQ1z817hcyxdMVWC+eAg97i3QsE8
# f/+nwrigV9CIv9jqdBdMUIRLm4XhyuDspksgBAQUJ1XYmmVSmFwh2ej31m/qI8fK
# fu0v6N6udkcg+5eoWEOL873hKAA+vjq30tM5Zp74fMHZahnvgjThgaJY6Z6OsCyX
# 6Pgxl3Z1gym1IqQFz0nOdTMnzsQrAJbV8z2FWMKgHayg01nVoXlo5FMnNgIdItJC
# v+4qX5sfRJIENJcRKMNY4dQUqbO1004+HXECLbge8pR7vsUli06xjLBkSbt/9M6r
# x3lfDGKavPrKfsPk1H+eTlge/43IjJk+mXMgZxmyvrvgnyVulxRvz7ABKJ+VBUeq
# CDrAuAK4tm5BIxKu6cg4CcmlqsDXwq6Sb+NdsbxTv0Deop73WZR3HCamRNU1JXkA
# eXBY4QSuVA96s5TnlfZWZytIY9NmyjN48ov+ly2fOkbv/xxoUNFBY8TApSJZ/Veo
# 4EvGlIfgxjv668n/2eyt67E00dGC3idTbaWYeGjgUKVyNPpxicDOnM3NTwMP3/0k
# DZbvfoJcwfhPVoFMdV7ZvJKA3i8v11HdaEI0urfjm5nJWbyik6+++skan9F/femL
# eRTnH2hr5sUV+eQAl2YhGuBElLmKf/HqTCeNs3lwrUQsnb9bPNc=
# =fK8K
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 22 Oct 2024 15:08:05 BST
# gpg: using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <[email protected]>" [full]
# gpg: aka "Daniel P. Berrange <[email protected]>" [full]
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF
* tag 'misc-fixes-pull-request' of https://gitlab.com/berrange/qemu:
gitlab: enable afalg tests in fedora system test
ui: validate NUL byte padding in SASL client data more strictly
ui: fix handling of NULL SASL server data
ui/vnc: don't check for SSF after SASL authentication on UNIX sockets
ui/vnc: fix skipping SASL SSF on UNIX sockets
ui/vnc: don't raise error formatting socket address for non-inet
ui/vnc: don't return an empty SASL mechlist to the client
crypto/hash-afalg: Fix broken build
include/crypto: clarify @result/@result_len for hash/hmac APIs
tests: correctly validate result buffer in hash/hmac tests
crypto/hash: avoid overwriting user supplied result pointer
util: don't set SO_REUSEADDR on client sockets
sockets: Remove deadcode
crypto: Remove unused DER string functions
Signed-off-by: Peter Maydell <[email protected]>
Commit: e67b7aef7c7f67ecd0282e903e0daff806d5d680
https://github.com/qemu/qemu/commit/e67b7aef7c7f67ecd0282e903e0daff806d5d680
Author: Peter Maydell <[email protected]>
Date: 2024-10-24 (Thu, 24 Oct 2024)
Changed paths:
M block/block-backend.c
M block/gluster.c
M block/raw-format.c
M block/ssh.c
M block/vdi.c
M monitor/monitor.c
M qapi/block-core.json
M tests/qemu-iotests/211.out
M tests/qemu-iotests/tests/backup-discard-source
Log Message:
-----------
Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging
Block layer patches
- Event throttling for BLOCK_IO_ERROR
- iotests: Fix backup-discard-source test for XFS
- Coverity fixes
- raw-format: Fix error message for invalid offset/size
# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmcX1wQRHGt3b2xmQHJl
# ZGhhdC5jb20ACgkQfwmycsiPL9aWKA//cyG+Q3EXLouSu2Ob04RArX8HgAzLmHL3
# Fx9x6BbDtusPfzxKVLqhJhJ5/oRyk0QWkdZKGNSxinLD3DBJ6q6FMNaWhuvzOBcy
# iHnWlMfwEIBl5vFJwM5Q/d7F2afOUiVSeR7E4TQn063cBo96qIrAD7DRLM01jBEN
# d9+9nkBruwgmxZJIr3WTsqjDoTqflcjxA6Adp/WkzVXBMMYqcsuReXQtrgfFooKw
# yhjkHq5nFKzebvK+BLjA0ytuvUlsRqLYDXN+bAk/rC6oCgbzygAjNwL5kUEYnV1r
# lVRSOxRUlet4v2GFCvplxw5tX3aJzlWB50v7d+oaBYR72htTtPeIZzadBJySdtSk
# DxEUR5kTcGK/vSI+WOapTVK+qU+Wr+6lFwGOL0zEYZyfvpyoFwfAlkjAUbf27FzX
# BDIL+hi9aVr+ZDooqcs0XUjGe1/1B+8SaNqMexqDUjxGDN4OfZhdQKD6uTjabc07
# aiZqKH1ZWViQlNgMcqpXecXS+r+Qc+R6Qga/iwJuhhPKp3VhUEtuDaHajPiTx17q
# 157CedcXxXKPRnNC/IneU0lOageknCLpRpIHZi3pYgcyfX1evE8CgF0aLZsN8tTv
# cdFJh7S89CknvK1sL18pcbV5/mtpDH/0DIWGg4d98O9X8Y/vluYEqSf6kPrjg6lR
# aVHU4/E8p8Y=
# =c+28
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 22 Oct 2024 17:47:00 BST
# gpg: using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
# gpg: issuer "[email protected]"
# gpg: Good signature from "Kevin Wolf <[email protected]>" [full]
# Primary key fingerprint: DC3D EB15 9A9A F95D 3D74 56FE 7F09 B272 C88F 2FD6
* tag 'for-upstream' of https://repo.or.cz/qemu/kevin:
raw-format: Fix error message for invalid offset/size
block-backend: per-device throttling of BLOCK_IO_ERROR reports
qapi: add qom-path to BLOCK_IO_ERROR event
iotests/backup-discard-source: don't use actual-size
iotests/backup-discard-source: convert size variable to be int
block/vdi.c: Make SECTOR_SIZE constant 64-bits
tests/qemu-iotests/211.out: Update to expect MapEntry 'compressed' field
block/ssh.c: Don't double-check that characters are hex digits
block/gluster: Use g_autofree for string in qemu_gluster_parse_json()
Signed-off-by: Peter Maydell <[email protected]>
Compare: https://github.com/qemu/qemu/compare/55522f72149f...e67b7aef7c7f
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
