On Mon, Oct 30, 2023 at 7:15 AM Akihiko Odaki <akihiko.od...@daynix.com>
wrote:
> virtio-net can report hash values even if the peer does not have a
> virtio-net header.
>
> Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
> ---
> hw/net/virtio-net.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index e30105884c..bdb4579f98 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -774,8 +774,6 @@ static uint64_t virtio_net_get_features(VirtIODevice
> *vdev, uint64_t features,
> virtio_clear_feature(&features, VIRTIO_NET_F_HOST_USO);
> virtio_clear_feature(&features, VIRTIO_NET_F_GUEST_USO4);
> virtio_clear_feature(&features, VIRTIO_NET_F_GUEST_USO6);
> -
> - virtio_clear_feature(&features, VIRTIO_NET_F_HASH_REPORT);
> }
>
>
IMO, we should not enable any advanced features for backends without
vnet_hdr unless we have a strong reason to do so.
( HOST_TSO and GUEST_TSO are performance boosters and they are not
supported without vnet_hdr )
I'd rather disable also RSS under this "if".
> if (!peer_has_vnet_hdr(n) || !peer_has_ufo(n)) {
> --
> 2.42.0
>
>
