On 28/11/23 19:06, Daniel P. Berrangé wrote:
On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote:
Anyway, when a maintainer wants to merge a tree, I would expect to
have a MR opened against 'master' in qemu-project/qemu. The CI
ought to then run and if it is all green, then someone would approve
it to merge to master.
It seems to me that we should also have a group of people approving
the MR.
Yes, while we could have one designated gate keeper approving all
MRs, that would defeat some of the benefit of MRs. So likely would
be good to have a pool, and also setup the config so that the owner
of an MR is not allow to approve their own MR, to guarantee there
is always a 2nd pair of eyes as sanity check.
Are all our tests already on GitLab? Last time I remember Peter still
had manual tests.
