On 24/1/24 23:59, Richard Henderson wrote:
On 1/24/24 20:16, Philippe Mathieu-Daudé wrote:
Hoist the CPUClass argument from most of these internal helpers:

  - check_for_breakpoints_slow
  - check_for_breakpoints()
  - cpu_tb_exec()
  - cpu_exec_enter()
  - cpu_exec_exit()
  - cpu_handle_halt()
  - cpu_handle_debug_exception()
  - cpu_handle_exception()
  - need_replay_interrupt()
  - cpu_handle_interrupt()
  - cpu_loop_exec_tb()
  - cpu_exec_loop()
  - cpu_exec_setjmp()

to the following ones with external linkage:

  - lookup_tb_ptr()
  - cpu_exec_step_atomic()
  - cpu_exec()

Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org>
---
  accel/tcg/cpu-exec.c | 82 ++++++++++++++++++++------------------------
  1 file changed, 37 insertions(+), 45 deletions(-)

I'm not so keen on this.  Does it really make a difference?
What about simply making more use of CPUState->cc instead?

TIL CPUState->cc... Which makes me wonder why this isn't handler
generically via QOM macros.



r~


Reply via email to