On 12/02/2024 17:17, Markus Armbruster wrote: > Joao Martins <joao.m.mart...@oracle.com> writes: > >> Allow disabling hugepages to be dirty track at base page >> granularity in similar vein to vfio_type1_iommu.disable_hugepages >> but per IOAS. >> >> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> > > [...] > >> diff --git a/qapi/qom.json b/qapi/qom.json >> index 84af23fe245d..9ad27e2b939b 100644 >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -809,7 +809,7 @@ >> # Since: 9.0 >> ## >> { 'struct': 'IOMMUFDProperties', >> - 'data': { '*fd': 'str' } } >> + 'data': { '*fd': 'str', '*hugepages': 'bool' } } >> >> ## >> # @RngProperties: > > Missing documentation for the new member. > > The latest QAPI PR is making this a hard error. >
Gah, sorry. I think I didn't have that PR yet as I didn't hit any build errors. Missing the doc was pure distraction. Will fix it for the next version. Joao