On Mon, 12 Feb 2024 at 15:20, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > On Fri, Feb 09, 2024 at 06:31:03PM +0100, Kevin Wolf wrote: > > Since commit effd60c8 changed how QMP commands are processed, the order > > of the block-commit return value and job events in iotests 144 wasn't > > fixed and more and caused the test to fail intermittently. > > > > Change the test to cache events first and then print them in a > > predefined order. > > > > Waiting three times for JOB_STATUS_CHANGE is a bit uglier than just > > waiting for the JOB_STATUS_CHANGE that has "status": "ready", but the > > tooling we have doesn't seem to allow the latter easily. > > > > Fixes: effd60c878176bcaf97fa7ce2b12d04bb8ead6f7 > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2126 > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > --- > > tests/qemu-iotests/144 | 12 +++++++++++- > > tests/qemu-iotests/144.out | 2 +- > > 2 files changed, 12 insertions(+), 2 deletions(-) > > Thank you! > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Thanks; I'm applying this directly as a CI fix. -- PMM