Hi Thomas, On Fri, Mar 08, 2024 at 02:20:45PM +0100, Thomas Huth wrote: > Date: Fri, 8 Mar 2024 14:20:45 +0100 > From: Thomas Huth <th...@redhat.com> > Subject: Re: [PATCH 03/14] hw/core/machine-smp: Simplify variables' > initialization in machine_parse_smp_config() > > On 06/03/2024 10.53, Zhao Liu wrote: > > From: Zhao Liu <zhao1....@intel.com> > > > > SMPConfiguration initializes its int64_t members as 0 by default. > > Can we always rely on that? ... or is this just by luck due to the current > implementation? In the latter case, I'd maybe rather drop this patch again. >
Thanks for the correction, I revisited and referenced more similar use cases, and indeed, only if the flag "has_*" is true, its corresponding field should be considered reliable. Keeping explicit checking on has_* and explicit initialization of these topology variables makes the code more readable. This patch is over-optimized and I would drop it. Regards, Zhao
