On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen <lee.es...@nowonline.co.uk> wrote: >> Signed-off-by: Lee Essen <lee.es...@nowonline.co.uk> >> >> --- >> >> scripts/tracetool | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > I'm going to spend some time today reviewing recent tracing patches. > I'd prefer to move to a Python version of tracetool rather than worry > about the shell quirks across all host platforms. > > If the Python rewrite cannot be merged for 1.1 then it makes sense to > go with shell portability fix.
Hi Stefan, While you are looking at this, there are a couple of other related issues worth having in the back of your mind: 1. "self" is a reserved word in Solaris/Illumos trace, and it's used in a few trace calls. 2. "bool" isn't recognised by default, again used in a couple of traces ... could be fixed by typedef, but switching to int is probably better (imho) 3. Some work is needed on the linking stage when using Solaris/Illumos dtrace. You need to provide all the objs to the dtrace -G call in order to get an object generated that includes all of the relevant symbols in it. Happy to provide more detail if needed. Cheers, Lee.